-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle build script improvements #3062
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also needs more hacky code than benefits. Builds will be faster too.
…n project() objects. Even if it was, a repositories {} inside a build.gradle file doesn't override, it appends (confirmed with `println(repositories.collect())` before and after the block; so globally declared repos might win in resolution.
imports plugins { } apply from: description dependencies ... everything else and make plugin syntax consistent. Also fix ordering dependency on description being set before including a file.
Change: junitJupiterExtensionTest and junitJupiterInlineMockMakerExtensionTest had the javadoc task enabled.
Change: memory-test, osgi-test, junitJupiterExtensionTest and junitJupiterInlineMockMakerExtensionTest had no java compatibility declared, now it's 11.
Change: extTest, junitJupiterParallelTest, groovyTest, groovyInlineTest had no java compatibility declared, now it's 11. Change: extTest, junitJupiterParallelTest, groovyTest, groovyInlineTest, kotlinReleaseCoroutinesTest and kotlinTest had the javadoc task enabled.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3062 +/- ##
=========================================
Coverage 85.45% 85.45%
Complexity 2888 2888
=========================================
Files 329 329
Lines 8801 8801
Branches 1093 1093
=========================================
Hits 7521 7521
Misses 992 992
Partials 288 288 ☔ View full report in Codecov by Sentry. |
TimvdLippe
approved these changes
Jul 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step towards #2898
This is in preparation for an other PR introducing toolchains which is a cross-module configuration. I did some generalization and consistency improvements to make it easier to make global changes. Some of the diffs in the PR might look strange, I recommend looking commit by commit to make sense of them.
Many modules already had
java-library.gradle
included. So I created a paralleljava-test.gradle
. With this there's now two named types of modules. Each subproject belongs to one of these types, except:There are some special-setup modules which still extend one of the named modules:
There were several (test) modules missing Java compatiblility declaration:
Testing:
gradlew clean
followed bygradlew publishAllPublicationsToMavenRepository --no-build-cache
rootProject/build/repo/
Test matrix:
-Pmockito.test.java=11
The changes all looked expected. Diffs were:
master
already.Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>
in the description if relevantFixes #<issue number>
if relevant